Skip to content

Contributing Page->Sir Lancebot: update description#882

Merged
wookie184 merged 5 commits into
python-discord:mainfrom
Ibrahim2750mi:contributing/sir-lancebot-description
Feb 27, 2023
Merged

Contributing Page->Sir Lancebot: update description#882
wookie184 merged 5 commits into
python-discord:mainfrom
Ibrahim2750mi:contributing/sir-lancebot-description

Conversation

@Ibrahim2750mi
Copy link
Copy Markdown
Contributor

@Ibrahim2750mi Ibrahim2750mi commented Feb 21, 2023 •
edited
Loading

Closes #880 and Closes #881

  • Removes typo for the Admins role being spelt Admin
  • Added the TRASHCAN_EMOJI as needed
  • Added code blocks for channel names

@Ibrahim2750mi
Contributing Page->Sir Lancebot: update description
d091b1d 
+ Removes typo for the `Admins` role being spelt `Admin`
+ Added the `TRASHCAN_EMOJI` as needed
+ Added code blocks for channel names
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 21, 2023 •
edited
Loading

✅ Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit 394f5db
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/63fd3eecb094c6000808ad8d
😎 Deploy Preview https://deploy-preview-882--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 21, 2023 •
edited
Loading

Coverage Status

Coverage: 100.0%. Remained the same when pulling 394f5db on Ibrahim2750mi:contributing/sir-lancebot-description into 21e11ed on python-discord:main.

wookie184
wookie184 reviewed Feb 25, 2023
View reviewed changes
Comment thread pydis_site/apps/content/resources/guides/pydis-guides/contributing/sir-lancebot.md Outdated
@Ibrahim2750mi Ibrahim2750mi mentioned this pull request Feb 25, 2023
Merged
wookie184
wookie184 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wookie184 wookie184 enabled auto-merge February 27, 2023 20:46
Xithrius
Xithrius approved these changes Feb 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@wookie184 wookie184 merged commit 21127db into python-discord:main Feb 27, 2023
@Ibrahim2750mi Ibrahim2750mi deleted the contributing/sir-lancebot-description branch February 28, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xithrius Xithrius Xithrius approved these changes

@wookie184 wookie184 wookie184 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Contributing to Sir Lancebot->Envrionment variables->Description has mistakes Contributing to Sir Lancebot page missing important env variable

4 participants

@Ibrahim2750mi @coveralls @Xithrius @wookie184