Skip to content

Make unittests independent of GitHub#948

Merged
ChrisLovering merged 2 commits into
mainfrom
independent-unit-tests
Apr 22, 2023
Merged

Make unittests independent of GitHub#948
ChrisLovering merged 2 commits into
mainfrom
independent-unit-tests

Conversation

@jchristgit
Copy link
Copy Markdown
Contributor

This fixes a problem where running the unit tests successively a lot would result in 403 ratelimit exceeded errors being thrown due to the GitHub API being called by the app.

Fixes #918

@jchristgit jchristgit requested a review from ks129 as a code owner April 21, 2023 19:15
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 21, 2023

Deploy Preview for pydis-static failed.

Name Link
🔨 Latest commit 2775161
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/6443d4975a264e0008283813

@jchristgit jchristgit force-pushed the independent-unit-tests branch from 3496f6c to 8b25b88 Compare April 21, 2023 19:17
This fixes a problem where running the unit tests successively a lot
would result in 403 ratelimit exceeded errors being thrown due to the
GitHub API being called by the app.

Fixes #918
@jchristgit jchristgit force-pushed the independent-unit-tests branch from 8b25b88 to a29c403 Compare April 21, 2023 19:21
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 21, 2023

Coverage Status

Coverage: 100.0%. Remained the same when pulling 2775161 on independent-unit-tests into 12b28f9 on main.

@jchristgit jchristgit requested a review from wookie184 April 21, 2023 19:41
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@wookie184 wookie184 enabled auto-merge April 22, 2023 12:35
@ChrisLovering ChrisLovering disabled auto-merge April 22, 2023 12:55
@ChrisLovering ChrisLovering merged commit aa303ed into main Apr 22, 2023
@ChrisLovering ChrisLovering deleted the independent-unit-tests branch April 22, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit tests depend on external resources

4 participants