Edit on GitHub feature for content#949
Conversation
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jchristgit
changed the title
jchristgit
changed the title
|
Comparing https://deploy-preview-949--pydis-static.netlify.app/pages/guides/pydis-guides/contributing/sir-lancebot/ to https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/sir-lancebot/ it seems like this causes the rest of the page to drop down a bit. Before: After: Any ideas on why this is? |
|
@wookie184 yes I have seen that, but I have no idea what causes it. Inspecting the layout in Firefox I concluded that it's no margin or padding from the element itself. I also concluded that it's probably not noticeable by anybody and was hoping I could sweep it under the rug. Unfortunately, you have crossed through my plan to do it. Any other idea where we can check what's causing the surplus whitespace apart from the layout box in devtools? I also tried to use a |
|
@jchristgit See @hedyhli's messages here for some solutions |
|
I saw these but I don't really have the CSS-fu to drive it to the finish line with the vertical stacking :( |
|
Hey there, so I've played around with the HTML a little and it seems this patch works: Basically comparing the elements from before this PR and after, the container appears to gained a height, and the breadcrumb Hopefully this diff isn't a 'hacky' fix though (otherwise it might pose problems in the future). Note: If you compare the positioning of sub-articles and edit-on-gh before and after applying the patch, you might notice the two having moved towards the right a little, it could possibly be fixed with something like a |
- Using `if pages` to check whether the page is an article or category doesn't work for /pages/guides - I still need to modify the styling and position of the button a bit - Should probably just use a static method and put src_url as context instead of having a template tag
- Before the title - Aligned left - more mobile-friendly - Simpler page structure - I personally don't think it makes sense for a simple link to a page's source be a button. Plus, it's similar to the style of other docs like VS Code
jchristgit
force-pushed
the
hedyhli-edit-on-github
branch
from
9053b55 to
dc17b3d
Compare
5 participants
Pulled from #626 to allow maintainer edits
Hidden in mobile:
Closes #459.