Skip to content

Update env var key references in the sir-lancebot's contribution guide#962

Merged
wookie184 merged 5 commits into
mainfrom
update-sir-lancebot-contrib-guide
May 7, 2023
Merged

Update env var key references in the sir-lancebot's contribution guide#962
wookie184 merged 5 commits into
mainfrom
update-sir-lancebot-contrib-guide

Conversation

@shtlrs
Copy link
Copy Markdown
Contributor

@shtlrs shtlrs commented May 6, 2023

This Pull Request updates Sir-Lancebot's contribution guide to reference the new env variable keys changed in this pr

@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2023

Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit 804ef75
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/6457bd19868149000761cfb7
😎 Deploy Preview https://deploy-preview-962--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@coveralls
Copy link
Copy Markdown

coveralls commented May 6, 2023

Coverage Status

Coverage: 100.0%. Remained the same when pulling 804ef75 on update-sir-lancebot-contrib-guide into 748a170 on main.

fix sir lancebot pg env var name
@shtlrs shtlrs requested a review from wookie184 May 7, 2023 09:39
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mention of #sir-lancebot-commands on line 60 that should be changed to #sir-lancebot-playground.

[**Full environment variable reference for this project.**](../sir-lancebot/env-var-reference)

---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line below this one but I can't comment on it, USE_FAKEREDIS -> REDIS_USE_FAKEREDIS

@shtlrs shtlrs requested a review from wookie184 May 7, 2023 15:00
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wookie184 wookie184 merged commit 20a36a5 into main May 7, 2023
@wookie184 wookie184 deleted the update-sir-lancebot-contrib-guide branch May 7, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants