Skip to content

Conversation

@sandipan898
Copy link
Contributor

Pull Request Template

Automated voice prescription generator -

Generates Prescriptions in the form of PDF Files by recognizing the voice inputs. When the main code being executed, information are to be given by following the instructions.

Issue no.(must) - #364

Self Check(Tick After Making pull Request)

  • This issue was assigned to me.
  • One Change in one Pull Request
  • My file is in proper folder (Name of folder should be in lowercase with no space in between)
  • I am following clean code and Documentation and my code is well linted with flake8.
  • I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! 🎉 @sandipan898 for making your first PR. We will review the changes soon and merge finally.😊 Do give a star ⭐ meanwhile if you like this project.

@pawangeek
Copy link
Contributor

Fix linting issues, and rename folder to just 'prescription_generator'

@pawangeek pawangeek linked an issue Aug 20, 2021 that may be closed by this pull request
1 task
@sandipan898
Copy link
Contributor Author

@pawangeek please check and let me know if any changes needed.

@pawangeek
Copy link
Contributor

Sandeep see the file changes tab, Just make changes in by adding your folder, If you're messed with something, clone the repo again and add your folder

@sandipan898
Copy link
Contributor Author

sandipan898 commented Aug 20, 2021

@pawangeek What things need to be changed? can you please guide me a bit so that I can do the needful.
Else can make another pull request addressing the same issue?

@pawangeek
Copy link
Contributor

@pawangeek What things need to be changed? can you please guide me a bit so that I can do the needful.
Else can make another pull request addressing the same issue?

Yup create a new PR, that's better

@sandipan898
Copy link
Contributor Author

One thing to clarify, do I need to fork it again or I can just clone my already forked repo and make changes again?
As this is my first ever contribution I'm facing a little bit problem managing it, so any kind of guidance will be grateful for me.

@pawangeek
Copy link
Contributor

pawangeek commented Aug 20, 2021

I recommend to fork it again, and create new PR

@sandipan898
Copy link
Contributor Author

I've created a fresh pull request. Please check it here #384

@pawangeek pawangeek added the duplicate This issue or pull request already exists label Aug 20, 2021
@pawangeek pawangeek closed this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automated Voice based Prescription Generator

2 participants