Skip to content

Conversation

@jayaganeshkumar
Copy link
Contributor

Pull Request Template

script name - solve_sudoku.py

What have you Changed

what you changed in the codebase.write here

Added new folder named "Sudoku-Solver" with files: "README.md", "solve_sudoku.py".

Issue no.(must) - #6

Self Check(Tick After Making pull Request)

  • This issue was assigned to me.
  • One Change in one Pull Request
  • My file is in proper folder (Name of folder should be in lowercase with no space in between)
  • I am following clean code and Documentation and my code is well linted with flake8.
  • I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

@pawangeek pawangeek changed the title Added Sudoku Solver python script and please label the PR with "hacktoberfest-accepted" and merge it. Added Sudoku Solver Oct 8, 2020
@pawangeek pawangeek linked an issue Oct 8, 2020 that may be closed by this pull request
2 tasks
@pawangeek
Copy link
Contributor

Yeah, sure I will add that tag, but first, you should enable linting

@jayaganeshkumar
Copy link
Contributor Author

jayaganeshkumar commented Oct 8, 2020

@pawangeek How to do that? These lint errors are happening because of comments in the code.

@pawangeek
Copy link
Contributor

@jayaganeshkumar Just put a space between # and rest comment

@jayaganeshkumar
Copy link
Contributor Author

Can I edit the file in this PR only?? @pawangeek

@pawangeek
Copy link
Contributor

Yes you can just go to file and click on 3 dots -> Edit this file and make changes or you can open a new issue if you're unable to do so

@pawangeek
Copy link
Contributor

You can use this site to correct linting

@jayaganeshkumar
Copy link
Contributor Author

@pawangeek done! can you check it now?

@pawangeek
Copy link
Contributor

Thanks for your contribution @jayaganeshkumar. Leave a star to encourage me for creating more such tasks :)

@pawangeek pawangeek merged commit b581c64 into python-geeks:main Oct 8, 2020
@pawangeek pawangeek added the hacktoberfest-accepted Supporting completion of hacktober fest label Oct 8, 2020
@jayaganeshkumar
Copy link
Contributor Author

Thank you @pawangeek . Already starred the repo.

@pawangeek
Copy link
Contributor

@all-contributors please add @jayaganeshkumar for code

@allcontributors
Copy link
Contributor

@pawangeek

I've put up a pull request to add @jayaganeshkumar! 🎉

@pawangeek pawangeek mentioned this pull request Oct 9, 2020
5 tasks
@maxily1 maxily1 added the testing verifying scripts label Oct 13, 2020
@maxily1
Copy link
Collaborator

maxily1 commented Oct 13, 2020

Hey, The instructions in the README.md file are unclear.
Could you please clarify the instructions?
As of now I am getting such error:

Traceback (most recent call last):
  File "solve_sudoku.py", line 68, in <module>       
    solve_sudoku()  # calls the solve function       
  File "solve_sudoku.py", line 49, in solve_sudoku   
    if is_number_valid(row, col, n):
  File "solve_sudoku.py", line 10, in is_number_valid
    if grid[i][col] == num:
IndexError: list index out of range

@pawangeek pawangeek added the bug Something isn't working label Oct 13, 2020
@jayaganeshkumar
Copy link
Contributor Author

@maxily1 you need to enter the board with 0s in place of empty places in the board

@jayaganeshkumar
Copy link
Contributor Author

@maxily1 you need to enter only 9 numbers with spaces for each line in input

@pawangeek
Copy link
Contributor

sol

I think it's working fine for me @maxily1 can you show me your logs

@jayaganeshkumar
Copy link
Contributor Author

@pawangeek yeah

@pawangeek
Copy link
Contributor

And @maxily1 if you see any bug in the first run don't need to report here, you should open a new issue there is a template of the bug report, Reporting it here, send unwanted notifs to the author

@pawangeek pawangeek removed the bug Something isn't working label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Supporting completion of hacktober fest testing verifying scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sudoku solver

3 participants