Skip to content

Conversation

@aayuv17
Copy link
Contributor

@aayuv17 aayuv17 commented Oct 8, 2020

Pull Request Template

script name - To-Do List Application

What have you Changed
Added a todo list application made using Python's flask framework

Issue no.(must) - #35

Self Check(Tick After Making pull Request)

  • This issue was assigned to me.
  • One Change in one Pull Request
  • My file is in proper folder (Name of folder should be in lowercase with no space in between)
  • I am following clean code and Documentation and my code is well linted with flake8.
  • I have added README.md and requirements.txt with my script

@pawangeek pawangeek linked an issue Oct 8, 2020 that may be closed by this pull request
5 tasks
@pawangeek
Copy link
Contributor

Hey @aayuv17. Can you please enable linting in code? You can use this site http://pep8online.com/ to check your .py file.

@aayuv17
Copy link
Contributor Author

aayuv17 commented Oct 8, 2020

Hey, so I have performed linting on the python code...just wanted to point out that the site you recommended and the tool being used for checking are following different rules in some cases so I installed the flake8 module and used that. Maybe if others face issues with the site you can tell them to do the same.

@pawangeek
Copy link
Contributor

Thanks for your contribution and valuable advice @aayuv17. Leave a star on the repo to encourage me for creating more such tasks :)

@pawangeek pawangeek merged commit 34e643b into python-geeks:main Oct 8, 2020
@pawangeek pawangeek added the hacktoberfest-accepted Supporting completion of hacktober fest label Oct 8, 2020
@pawangeek
Copy link
Contributor

@all-contributors please add @aayuv17 for code

@allcontributors
Copy link
Contributor

@pawangeek

I've put up a pull request to add @aayuv17! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Supporting completion of hacktober fest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Todo App

2 participants