Skip to content

Conversation

@DevMahmoud10
Copy link

Pull Request Template

script name -
links_extractor

What have you Changed
adding links extractor script

Issue no.(must) - #54

Self Check(Tick After Making pull Request)

  • This issue was assigned to me.
  • One Change in one Pull Request
  • My file is in proper folder (Name of folder should be in lowercase with no space in between)
  • I am following clean code and Documentation and my code is well linted with flake8.
  • I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! 🎉 @DevMahmoud10 for making your first PR. We will review the changes soon and merge finally.😊 Do give a star ⭐ meanwhile if you like this project.

@pawangeek pawangeek linked an issue Oct 8, 2020 that may be closed by this pull request
2 tasks
@pawangeek
Copy link
Contributor

hey @DevMahmoud10 can you please enable linting in code (flake8 here)

@DevMahmoud10
Copy link
Author

hey @DevMahmoud10 can you please enable linting in code (flake8 here)

Done

@pawangeek
Copy link
Contributor

Perfect @DevMahmoud10 Thanks for your valuable contribution

@pawangeek pawangeek merged commit b0249e4 into python-geeks:main Oct 11, 2020
@pawangeek pawangeek added the hacktoberfest-accepted Supporting completion of hacktober fest label Oct 11, 2020
@pawangeek
Copy link
Contributor

@all-contributors add @DevMahmoud10 for code

@allcontributors
Copy link
Contributor

@pawangeek

I've put up a pull request to add @DevMahmoud10! 🎉

@pawangeek pawangeek mentioned this pull request Oct 7, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Supporting completion of hacktober fest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scraping links from Text file

2 participants