Skip to content

Conversation

@maheshschand
Copy link
Contributor

@maheshschand maheshschand commented Oct 9, 2020

Pull Request Template

script name - currency_converter.py

What have you Changed

Added a script to convert currency of one country to that of other country

Issue no.(must) - #43

Self Check(Tick After Making pull Request)

  • This issue was assigned to me.
  • One Change in one Pull Request
  • My file is in proper folder (Name of folder should be in lowercase with no space in between)
  • I am following clean code and Documentation and my code is well linted with flake8.
  • I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! 🎉 @maheshschand for making your first PR. We will review the changes soon and merge finally.😊 Do give a star ⭐ meanwhile if you like this project.

@maheshschand maheshschand changed the title Add Currency convertor Add Currency Converter Oct 9, 2020
@pawangeek
Copy link
Contributor

Hey @maheshschand, Thanks for your contribution. Leave a star on the repo to encourage me more for creating such tasks :)

@pawangeek pawangeek linked an issue Oct 9, 2020 that may be closed by this pull request
2 tasks
@pawangeek pawangeek merged commit bbb1477 into python-geeks:main Oct 9, 2020
@pawangeek pawangeek added the hacktoberfest-accepted Supporting completion of hacktober fest label Oct 9, 2020
@maheshschand
Copy link
Contributor Author

Thank you

@pawangeek
Copy link
Contributor

@all-contributors please add @maheshschand for code

@allcontributors
Copy link
Contributor

@pawangeek

I've put up a pull request to add @maheshschand! 🎉

@pawangeek pawangeek mentioned this pull request Oct 1, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Supporting completion of hacktober fest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Currency Convertor

2 participants