Fix issue with publishing release#222
Merged
sethmlarson merged 2 commits intopython-hyper:mainfrom Mar 5, 2026
Merged
Conversation
hugovk
approved these changes
Mar 4, 2026
Contributor
Author
|
@hugovk showed up because I linked here on the PyPA discord. He also suggested migrating to trusted publishing, but I think that will need some help from @sethmlarson to adjust the PyPI settings. |
Member
|
@ngoldbaum I think we should configure trusted publishers. Let me do that quickly and then we can drop all the API token configurations. |
Member
|
@ngoldbaum Also, what is your PyPI username? I am going to invite you as a collaborator there, too. |
Member
|
@ngoldbaum You can delete the old tag since it was never published and re-push a new one. |
Contributor
Author
|
My PyPI username is Nathan.Goldbaum: https://pypi.org/user/Nathan.Goldbaum/ Looks like everything is OK here. I'll delete the tag now and push a new one once this is merged. |
sethmlarson
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c.f. #221 (comment)
I'm not 100% sure this will work. Unfortunately the only way to test it (I think?) is to merge this and push a new tag.
@sethmlarson should I push a
v1.2.1.1tag, or is it OK to simply move thev1.2.1.0tag to a version after this PR is merged, since the PyPI upload never happened?