Handle flow control changes via Settings #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
force-pushed
the
bug/settings-flow-control
branch
from
27e22eb to
f6944cb
Compare
Lukasa
added a commit
that referenced
this pull request
Sep 19, 2015
Handle flow control changes via Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in Settings frames can cause changes in flow control windows.
Nominally this is part of #5, but it arguably breaks #4 because Chrome sends an INITIAL_WINDOW_SIZE setting that is vastly higher than the standard flow control window size. hyper-h2 loses track of this, and so gets stuck waiting for a WindowUpdate that will never come. Chrome politely waits forever, and so nothing happens but a sad sad spinner.
A full solution will come in #5, but for now this gets us unblocked in this problem.