Enforce RFC 7540 rules about stream weights #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwlchan
force-pushed
the
awlc/weights
branch
from
981ab6e to
1724885
Compare
Lukasa
requested changes
Jan 22, 2017
Member
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
This looks really good! One small note about the testing.
test/test_priority.py
Outdated
| """ | ||
| with pytest.raises(priority.BadWeightError) as err: | ||
| priority.Stream(stream_id=0, weight=bad_weight) | ||
| assert err.value.args[0] == 'Stream weight should be an integer' |
Member
There was a problem hiding this comment.
Rather than test these by constructing the stream object directly, it might be better to use the public API methods for this test. That way, if we ever move this validation the tests will continue to reflect the actual intent.
alexwlchan
force-pushed
the
awlc/weights
branch
from
1724885 to
40e5d3d
Compare
Contributor
Author
|
Test updated; |
Member
|
Changeling entry? How very Strossian of you. |
Lukasa
requested changes
Jan 22, 2017
| assert ( | ||
| err.value.args[0] == | ||
| 'Stream weight must be between 1 and 256 (inclusive)') | ||
|
|
Member
There was a problem hiding this comment.
We should probably add variations of these tests that also call reprioritize.
Lukasa
approved these changes
Jan 22, 2017
Member
|
Cool, this looks good. We'll see if the tests pass, of course. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50.