Catch RecursionError in the regex format checker - #1540
Open
UlikGames wants to merge 1 commit into
Open
Conversation
re.compile raises RecursionError, not re.error, when a pattern nests deeply enough to blow the C stack, so the exception escaped the format checker instead of being turned into a FormatError.
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1538
re.compileraisesRecursionErrorrather thanre.errorwhen a pattern nests deeply enough to hit the C stack limit, so the checker'sraises=re.errordidn't cover it and the exception escaped the validator instead of being reported as an invalid instance.Added
RecursionErrorto the tuple, plus a test with"(" * 500. Same shape as theOverflowErrorcase in #1526, just a different exception type.Full test suite passes locally.