Skip to content

permission error fix in test_cluster_spooler.py teardown#1648

Merged
David-Baddeley merged 3 commits intopython-microscopy:masterfrom
barentine:moretests
Mar 6, 2026
Merged

permission error fix in test_cluster_spooler.py teardown#1648
David-Baddeley merged 3 commits intopython-microscopy:masterfrom
barentine:moretests

Conversation

@barentine
Copy link
Copy Markdown
Member

Addresses issue test passes, but in teardown the servers need a slight delay to close before releasing the temporary directory for deletion. Also works with a 0.1 s delay on my machine, but just to be safe... left it at 1 s.

image

Checklist:
The below is a list of things what will be considered when reviewing PRs. It is not prescriptive, and does not
imply that PRs which touch any of these will be rejected but gives a rough indication of where there is a potential
for hangups (i.e. factors which could turn a 5 min review into a half hour or longer and shunt it to the bottom
of the TODO list).

  • Does the PR avoid variable renaming in existing code, whitespace changes, and other forms of tidying? [There is a place for code tidying, but it makes reviewing
    much simpler if this is kept separate from functional changes. The auto-formatting performed by some editors is particulaly egregious and can lead to files with thousands
    of non-functional changes with a few functional changes scattered amoungst them]

If an enhancement (or non-trivial bugfix):

  • Has this been discussed in advance (feature request, PR proposal, email, or direct conversation)?
  • Does this change how users interact with the software? How will these changes be communicated?
  • Does this maintain backwards compatibility with old data?
  • Does this change the required dependencies?
  • Are there any other side effects of the change?

@David-Baddeley
Copy link
Copy Markdown
Contributor

just did a re-merge to see if we get clean tests.

@David-Baddeley David-Baddeley merged commit 2212b5f into python-microscopy:master Mar 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants