fix: return None for highlight_color when w:val is 'none' - #1581
Open
ChenfromChina123 wants to merge 2 commits into
Open
fix: return None for highlight_color when w:val is 'none'#1581ChenfromChina123 wants to merge 2 commits into
ChenfromChina123 wants to merge 2 commits into
Conversation
The example calls add_picture('monty-truth.png') which raises
FileNotFoundError when the file is not present in the working
directory. Wrap it in a try/except so the example runs out of
the box.
Closes python-openxml#128
Co-Authored-By: AtomCode (deepseek-v4-flash) <noreply@atomgit.com>
w:val="none" is a valid ST_HighlightColor value meaning the highlight is explicitly cleared, but it has no WD_COLOR_INDEX mapping, so reading font.highlight_color raised ValueError. Closes python-openxml#1559 Co-Authored-By: AtomCode (deepseek-v4-flash) <noreply@atomgit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
ValueError: WD_COLOR_INDEX has no XML mapping for 'none'when readingFont.highlight_coloron a run whose<w:highlight>element hasw:val="none".noneis a validST_HighlightColorvalue — Word writes it when a highlight is explicitly cleared.Closes #1559
Changes
src/docx/oxml/text/font.py:CT_RPr.highlight_valnow returnsNonewhen the raw attribute is"none"instead of attempting an enum conversion.Verification
python -m py_compile src/docx/oxml/text/font.pypasses.