fix: skip unsupported image parts when matching by sha1 - #1582
Open
ChenfromChina123 wants to merge 2 commits into
Open
fix: skip unsupported image parts when matching by sha1#1582ChenfromChina123 wants to merge 2 commits into
ChenfromChina123 wants to merge 2 commits into
Conversation
The example calls add_picture('monty-truth.png') which raises
FileNotFoundError when the file is not present in the working
directory. Wrap it in a try/except so the example runs out of
the box.
Closes python-openxml#128
Co-Authored-By: AtomCode (deepseek-v4-flash) <noreply@atomgit.com>
Unknown/unsupported image types (like SVG) are stored as generic Parts without a sha1 attribute, causing AttributeError during add_picture. Skip such parts when searching by SHA1 hash. Closes python-openxml#1565 Co-Authored-By: AtomCode (deepseek-v4-flash) <noreply@atomgit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
AttributeError: 'Part' object has no attribute 'sha1'triggered byadd_picturewhen an unsupported image type (e.g. SVG) was previously added and stored as a genericPart.Closes #1565
Changes
src/docx/package.py:ImageParts._get_by_sha1now skips image parts lacking asha1attribute (unknown/unsupported image types), mirroring the fix in python-pptx (commit 4c0fd125).Verification
python -m py_compile src/docx/package.pypasses.