test: cover single-page repository responses#10988
Open
LuBoys wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Relates-to: #3155
SinglePageRepositorytests previously used a subclass that overrides_get_page, so the production implementation was not exercised.This PR adds coverage for:
PackageNotFoundErrorwhen the page returns a 404 response.No production code or user-facing behavior is changed.
Testing
python -m pytest tests/repositories/test_single_page_repository.py --cov=poetry.repositories.single_page_repository --cov-report=term-missing -q— 5 passed, 100% coveragepython -m pytest tests/repositories --no-cov -q— 337 passedpython -m pytest --no-cov -q— 3175 passed, 27 skippedpre-commit run --files tests/repositories/test_single_page_repository.py— passedmypy tests/repositories/test_single_page_repository.py— passedAI assistance
OpenAI Codex assisted with identifying the coverage gap, drafting the tests, and running validation. The contributor reviewed the complete diff and test results.