Fix #2089: Make Python implementation type as part of the venv name.

[PetterS]

Resolves: #2089. Now "pypy" is part of the venv name so that it can be used together with poetry. Virtualenvs using Cpython will not change names to ensure backwards compatibility.

• Added tests for changed code.

[PetterS]

Does not yet work since the "-py" prefix is still hard-coded in a few more places in env.py. I don't know enough about how Poetry fetches its config to fix it right now.

When the following command is performed:

poetry env use /path/to/pypy3

Poetry prints:

Creating virtualenv poetry-0nHquv0u-pypy3.6 in /home/petter/.cache/pypoetry/virtualenvs
Using virtualenv: /home/petter/.cache/pypoetry/virtualenvs/poetry-0nHquv0u-py3.6

So it creates the correct environment, but then still decides to use the old one. Will update the rest of the places.

[PetterS]

It now works for me locally with pypy, so this is something that can be discussed.

[thedrow]

I'll give it a shot :)

[PetterS]

@abn would be nice if we could discuss this.

[abn]

In principle the change looks good. How would this handle reuse of an existing environment for the project?

[PetterS]

Since this PR only affects the name of the directory for Python implementations other than CPython, I think it should be fine?

[Secrus]

@PetterS are you still interested in bringing it to Poetry? If so, please merge changes from master branch and resolve potential conflicts. Whats more, please include some documentation on that matter.

[thedrow]

I'm still interested in this but I don't have the time to rebase it right now.

[PetterS]

Yes, I think it would be useful.

[PetterS]

Well this patch does not apply anymore. It has been 2 years!
But there is some more support for pypy now it seems: interpreter_name

perhaps it works now? Otherwise, it should be easier to set the environment name since the info is already fetched.

[thedrow]

It behaves exactly the same according to the code but yes, it should be much easier to implement this behavior now.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.