Skip to content

Fix Ruff lint violations - #118

Merged
timkpaine merged 1 commit into
mainfrom
fix-ruff-lint
Jul 27, 2026
Merged

Fix Ruff lint violations#118
timkpaine merged 1 commit into
mainfrom
fix-ruff-lint

Conversation

@timkpaine

Copy link
Copy Markdown
Member

Description

Update code for newly enforced Ruff rules without changing lint configuration. Remove a duplicate parameterized test case.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / code cleanup
  • CI / build configuration
  • Other (describe below)

Checklist

  • Linting passes (make lint)
  • Tests pass (make test)
  • New tests added for new functionality
  • Documentation updated (if applicable)
  • Changelog / version bump (if applicable)

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Test Results

75 tests   - 1   75 ✅  - 1   53s ⏱️ -8s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 60af0f6. ± Comparison against base commit df8c011.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
hatch_cpp.tests.test_projects.TestProject ‑ test_basic[test_project_override_classes0]
hatch_cpp.tests.test_projects.TestProject ‑ test_basic[test_project_override_classes1]
hatch_cpp.tests.test_projects.TestProject ‑ test_basic[test_project_override_classes]

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.45%. Comparing base (df8c011) to head (60af0f6).

Files with missing lines Patch % Lines
hatch_cpp/toolchains/common.py 91.07% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   94.20%   94.45%   +0.25%     
==========================================
  Files          14       14              
  Lines        1190     1173      -17     
==========================================
- Hits         1121     1108      -13     
+ Misses         69       65       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timkpaine
timkpaine merged commit cb3f360 into main Jul 27, 2026
5 of 6 checks passed
@timkpaine
timkpaine deleted the fix-ruff-lint branch July 27, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant