Skip to content

Support extract method of expressions with inline assignment (walrus operator)#365

Merged
lieryan merged 4 commits into
python-rope:masterfrom
lieryan:lieryan-357-extract-method-with-inline-assignment
Sep 5, 2021
Merged

Support extract method of expressions with inline assignment (walrus operator)#365
lieryan merged 4 commits into
python-rope:masterfrom
lieryan:lieryan-357-extract-method-with-inline-assignment

Conversation

@lieryan

@lieryan lieryan commented Sep 4, 2021

Copy link
Copy Markdown
Member

Fix #357.

@lieryan lieryan requested a review from mcepl September 4, 2021 14:23
@lieryan lieryan self-assigned this Sep 4, 2021
@lieryan lieryan force-pushed the lieryan-357-extract-method-with-inline-assignment branch from efe919f to eedd678 Compare September 4, 2021 14:37
@lieryan lieryan added this to the 0.20.0 milestone Sep 4, 2021

@mcepl mcepl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lieryan lieryan merged commit 6c1e539 into python-rope:master Sep 5, 2021
@lieryan lieryan deleted the lieryan-357-extract-method-with-inline-assignment branch September 5, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rope does not support extract method on expressions with Inline Assignment (walrus operator)

2 participants