Fix variables that are returned and/or turned into argument when extracting method in a loop

[lieryan]

Fix #112.

• Create ticket: unsafe refactoring: when extracting method, should detect and raise an error if variable scope cannot be determined #393

[lieryan]

Created #393 for this comment.

---

One maybe-bug with this refactoring:

def my_func():
    for dummy in range(10):
        i += 1

Current extract refactoring implementation produces:

def my_func():
    for dummy in range(10):
        i = aaa()

def aaa():
    i += 1
    return i

Arguably, the original code was non-sense to begin with, as i was undefined. When run, that code would've produced a NameError, so strictly speaking, this refactoring is garbage-in, garbage-out.

If i was assigned before, such as the below code, the current implementation would have produced correct refactoring:

def my_func():
    i = 0
    for dummy in range(10):
        i += 1

Maybe rope could catch this and refuse to refactor such code.