Implement async def, async for, and await syntax for method extraction#389
Merged
Conversation
Member
Author
|
Currently still failing cases: |
Member
Author
|
Currently still failing cases: |
In Python 3.6 and earlier, `async for` and `await` are only valid within an `async def`. This is a restriction that is later removed, but are causing tests to fail unnecessarily.
d7832bc to
bb858a6
Compare
Named expression is not a statement.
We need to be able to parse top-level `async`/`await` statements to parse the extracted snippet. Python supports `async`/`await` syntax since 3.5 but only in Python 3.8, that the `ast` supports PyCF_ALLOW_TOP_LEVEL_AWAIT which allows us to parse `async`/`await` outside of an `async def` block.
…oop_should_error_before_py38
1a2128c to
5aaaea5
Compare
async def, async for, and await syntax on patchedastasync def, async for, and await syntax for method extraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #375
Todo:
async def,async for, andawaitsyntax for method extraction #389 (comment)async def,async for, andawaitsyntax for method extraction #389 (comment)