Disallow combining of DaskStream and Stream objects #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This outright errors, which is the extreme of warning. Not sure if you wanted to go that far @CJ-Wright . |
Member
|
I guess one could come up with a very wonky use case which runs operations on the |
mrocklin
reviewed
May 2, 2018
|
|
||
| def __init__(self, upstream=None, upstreams=None, stream_name=None, | ||
| loop=None, asynchronous=None, ensure_io_loop=False): | ||
| from .dask import DaskStream |
Collaborator
There was a problem hiding this comment.
This creates a dependency on Dask?
| if (all(isinstance(u, DaskStream) for u in upstreams) != | ||
| any(isinstance(u, DaskStream) for u in upstreams)): | ||
| raise ValueError('Must combine only DaskStreams ' | ||
| 'or no DaskStreams') |
Collaborator
There was a problem hiding this comment.
Are there no valid use cases of doing this?
Member
Author
|
OK, we can close this as overenthusiastic, following comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172