Skip to content

Conversation

@CJ-Wright
Copy link
Member

This closes #173 with docs

@CJ-Wright
Copy link
Member Author

@mrocklin @martindurant I think this is ready for review!

@martindurant
Copy link
Member

(I think this will need to merge from master to pass)

@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #176 into master will increase coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   93.05%   93.53%   +0.47%     
==========================================
  Files          13       13              
  Lines        1483     1546      +63     
==========================================
+ Hits         1380     1446      +66     
+ Misses        103      100       -3
Impacted Files Coverage Δ
streamz/dataframe/core.py 92.17% <0%> (ø) ⬆️
streamz/sources.py 95.31% <0%> (+3.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a5fdc...3281779. Read the comment docs.

@martindurant
Copy link
Member

Please ignore what I said, seems to work fine and, magically, increases coverage. Perhaps the doc is picked up by doctest?

@mrocklin , happy with the words I suggested?

@mrocklin
Copy link
Collaborator

mrocklin commented Mar 26, 2019 via email

@martindurant
Copy link
Member

Understood.

Would you be interested in granting me rights to merge documentation PRs like this and close issues as I see fit? I would not merge real code which changes functionality (I know github doesn't differentiate) without your sayso.

@martindurant martindurant merged commit 35b8e9c into python-streamz:master Apr 10, 2019
@CJ-Wright CJ-Wright deleted the dask_gotcha branch April 10, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants