[#1526]: Preventing the problem of catching an empty list of signals - #1527
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 107 107
Lines 13239 13308 +69
Branches 1006 1010 +4
=======================================
+ Hits 13196 13265 +69
Misses 28 28
Partials 15 15
|
kaldown
changed the title
kaldown
changed the title
pquentin
requested changes
May 16, 2020
pquentin
left a comment
pquentin
left a comment
Member
There was a problem hiding this comment.
This looks good! I requested one small change on the exception type. What do you think?
kaldown
force-pushed
the
#1526
branch
2 times, most recently
from
May 16, 2020 09:59
5d9ede1 to
e3deb39
Compare
kaldown
changed the title
kaldown
changed the title
kaldown
force-pushed
the
#1526
branch
3 times, most recently
from
May 16, 2020 10:26
e7cf15c to
4905365
Compare
Contributor
Author
|
Finally, I won that |
oremanj
requested changes
May 16, 2020
Member
|
Also, please write "Closes #1526" in the PR description so that merging the PR will close the issue. Just listing the issue number isn't sufficient for that. |
…of signals. Newsfragment bugfix were added.
Contributor
Author
|
Thank you for the patient :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1526