Add docstrings for memory channel classes#3465
Conversation
A5rocks
left a comment
There was a problem hiding this comment.
Please appease CI! I'm not too sure about these new docstrings. I'm not sure my review comments are correct, but I think they would be more useful to readers at least.
A5rocks
left a comment
There was a problem hiding this comment.
Thanks for the changes. Just a couple nitpicks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3465 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19417 19423 +6
Branches 1317 1317
===============================================
+ Hits 19417 19423 +6
🚀 New features to boost your workflow:
|
|
I've made all the changes. Please review when you have time. Thanks! |
|
Hi! Thanks again for reviewing and approving the PR. Just wanted to check if there's anything else needed from my side before it can be merged. Thanks! |
|
Nothing else is necessary from you, I'm just waiting for someone else to approve/merge. |
CoolCat467
left a comment
There was a problem hiding this comment.
"for python objects" seemed a little weird but I can't think of a better description myself, looks good.
Summary
Add class docstrings for:
This improves the generated API documentation for these classes.