Update ruff#3476
Merged
Merged
Conversation
A5rocks
marked this pull request as ready for review
July 22, 2026 18:12
CoolCat467
approved these changes
Jul 23, 2026
Member
|
We could likely avoid these problems if we switched to ruff's formater instead of black, but if we were to do that I think it would be better served for another pull request. |
Member
|
After the acquiring of astral I am slightly wary of relying even more on them, but it shouldn't be a big jump to revert back to using black. |
Contributor
Author
|
Done: psf/black#5260 |
Contributor
Author
|
Hmm actually maybe it's just a matter of putting enough time in. I forgot which exact formatting loops made me give up, but it's probably possible to structure the code somehow to appease both black and ruff. I'm just not sure it's worth it. (... maybe I should open an issue here so it gets done eventually, maybe) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RUF105 in particular was being bad, because it would change our
noqatoruff:ignore, which thenblacklooks at and reformats, which ruff would see being on the wrong line and remove + apply fixes arbitrarily around the codebase. Basically a giant mess.I've disabled it. I wish we could get the nice human readable names (RUF106) without using
ruff:ignore, but that doesn't seem possible.