GeoJSON popup.

[ocefpaf]

This closes #100 and #3. Request #6 is a little bit trickier and will demand more thinking.

[ocefpaf]

@birdage Can you review. I hard-coded the onEachFeature call and function into the template. I am unsure of the impact that will have on non-pop GeoJSONs.

[birdage]

@ocefpaf this one cant be merged

[ocefpaf]

@birdage rebased and over to you.

[birdage]

looks good

[oztalha]

Thanks, not tested but looks promising ! I have a quick follow-up request though: In geoJSON file I only have the polygon data (and I don't want to modify the file), which I believe is the case for most of the people. Instead, I would like to keep popup contents in other places such as a column in a pandas dataframe or in a JSON (I can modify the file produced by data_out=data.json) as I would like to create maps with different popup contents but with the same layout. So, could you please also extend the feature so that we could be able to feed the popup content via data_1 JSON as an alternative to gjson_1 JSON ? Thanks again !

[ocefpaf]

Hi @oztalha,

We are running a little low on man power. To make sure your request will be attended one day you should open a new issue with that. We do not look for pending actions on merged PR and closed issues.

(Also, patches are welcome 😜 )

[oztalha]

Thanks. I will move out of my comfort zone and hopefully learn JS soon; then see me :-)