Skip to content

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Apr 21, 2015

@birdage Can you review and merge this one?

@birdage
Copy link
Contributor

birdage commented Apr 21, 2015

@ocefpaf i will when travis finishes 😄

@ocefpaf ocefpaf force-pushed the cartodb branch 2 times, most recently from d1bd066 to d4daee7 Compare April 22, 2015 16:06
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 22, 2015

I just re-based, pep8'd and added an example here.

@birdage over to you now.

birdage added a commit that referenced this pull request Apr 22, 2015
Added cartodb positron and dark_matter maps.
@birdage birdage merged commit ff24a85 into python-visualization:master Apr 22, 2015
@birdage
Copy link
Contributor

birdage commented Apr 22, 2015

@ocefpaf im seeing scroll bars on the right and bottom now tho?

@ocefpaf ocefpaf deleted the cartodb branch April 22, 2015 16:39
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 22, 2015

seeing scroll bars on the right and bottom

In the notebook? That is my inline_map() fault.

(BTW: we need an overhaul in how we display folium maps in IPython.)

@birdage
Copy link
Contributor

birdage commented Apr 22, 2015

yeah there are a few things we need to do 😄

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 22, 2015

Yep. BTW, can you take a quick look at: #110, #109, #106, and #102. I have some cahnges lined up but I want to avoid merge conflicts 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants