Fix up tox envs and their usage in travis#330
Merged
bbangert merged 5 commits intopython-zk:masterfrom Jun 1, 2015
Merged
Conversation
added 2 commits
May 28, 2015 10:27
Ensure that we have specific virtualenvs listed in tox that install the desired gevent versions and ensure that the .travis.yml file references them for usage. This also adds gevent (with no version restriction) to the py27, py26 builds and also adds eventlet (which is now py3.x compat) to the py33 and py34 builds so that we know it is working as expected. Fixes issue python-zk#328
bbangert
changed the title
Contributor
|
Not quite related to this, but I'd probably simplify this by only testing each Python version with gevent==0.13.8 and once with gevent without a version restriction / latest. Since we don't do any of the gevent monkey patching, I wouldn't even run the tests without gevent installed. Especially since gevent 1.0.2 was just released, and updating the gevent version is a bit tedious. And to go even further off-topic, we might just stop testing with gevent 0.13.x. The 1.0 line has had a stable release for 1.5 years now and a really good release candidate for 2.5 years. |
Contributor
Author
|
I'm fine with all the mentioned comments :) |
bbangert
added a commit
that referenced
this pull request
Jun 1, 2015
Fix up tox envs and their usage in travis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that we have specific virtualenvs listed in tox that install the
desired gevent and eventlet versions and ensure that the
.travis.ymlfile references them for usage.This also adds gevent (with no version restriction) to the py27, py26
builds (with postfix
-gevent) and also adds eventlet specific virtualenvs(with postfix
-eventlet) for making sure that eventlet and geventcontinues to work.
Fixes issue #328