chore: update MANIFEST.in to reflect changes to filenames#438
chore: update MANIFEST.in to reflect changes to filenames#438bbangert merged 1 commit intopython-zk:masterfrom
Conversation
|
Argh! Thanks! Can you update the commit message per the CONTRIBUTING doc? |
mrterry
changed the title
mrterry
changed the title
|
@bbangert I think it follows the style guide now. Please let me know if i misinterpreted something. |
|
Oh, the commit itself needs to be updated, ie: So that it indicates that it closes it inside the PR (the changelog tool will auto-link everything together). The easiest way to change it is to amend your commit and just change the message with 'git commit --amend', then force push to override the existing one. Sorry about the hassle! |
Looks like the .rst files got converted to .md, but MANIFEST.in wasn't updated. This also fixes the sdist, since setup.py expects README.md & CONTRIBUTING.md to be in the source tarball. closes python-zk#437
|
no worries. everybody has a slightly different process. please excuse the thrashing. |
|
Looks great, thanks! |
|
Will the fix be reflected in the tarball on pypi? |
|
Yes, I'm pushing a new tag for 2.3.1 that should be uploaded to pypi once tests pass. |
|
Thanks! |
|
Looks like 2.3.1 has been released, let me know if there's any other issues. |
3 participants
Looks like the .rst files got converted to .md, but MANIFEST.in wasn't
updated. This also fixes the sdist, since setup.py expects README.md &
CONTRIBUTING.md to be in the source tarball.
Closes #437