Skip to content

Conversation

@encukou
Copy link
Member

@encukou encukou commented May 4, 2021

miss-islington and others added 2 commits May 4, 2021 15:22
(cherry picked from commit 2f5baa1)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented May 4, 2021

Initially I opened GH-25852 which fixed this by checking in PyType_FromModuleAndSpec, but your fix looks like it actually targets the root of it. So I think it's better :).

Edit: Oops I just read your bpo message. Thanks for explaining the other reason too!

@ambv ambv merged commit ec18362 into python:3.9 May 4, 2021
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants