asyncore.py and "handle_error"

[jcea]

BPO	760475
Nosy	@jcea, @josiahcarlson

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/josiahcarlson'
closed_at = <Date 2008-07-07.05:05:34.924>
created_at = <Date 2003-06-25.13:11:28.000>
labels = ['library']
title = 'asyncore.py and "handle_error"'
updated_at = <Date 2008-07-07.05:05:34.923>
user = 'https://github.com/jcea'

bugs.python.org fields:

activity = <Date 2008-07-07.05:05:34.923>
actor = 'josiahcarlson'
assignee = 'josiahcarlson'
closed = True
closed_date = <Date 2008-07-07.05:05:34.924>
closer = 'josiahcarlson'
components = ['Library (Lib)']
creation = <Date 2003-06-25.13:11:28.000>
creator = 'jcea'
dependencies = []
files = []
hgrepos = []
issue_num = 760475
keywords = []
message_count = 5.0
messages = ['16595', '16596', '16597', '69215', '69378']
nosy_count = 3.0
nosy_names = ['jhylton', 'jcea', 'josiahcarlson']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue760475'
versions = ['Python 2.3']

[jcea]

When an uncached exception arises in "asyncore", the
method "handle_error" is called. This method calls
"self.close()" when it MUST call "self.handle_close()",
in order to support correctly the "delegation" design
pattern, for example.

[jhylton]

Logged In: YES
user_id=31392

Can you expand on your comments. I don't know what the
delegation design pattern you refer to is. Can you provide
an example of why it is necessary that asyncore not call
close()?

[josiahcarlson]

While the default .close() method is called inside .handle_close(), not calling .handle_close() in asyncore prevents any subclassed .handle_close() behavior to be run.

Say, for example, that a user has written a subclass where within .handle_connect() the socket is registered somewhere (perhaps for I/O statistics in an FTP or Bittorrent application). Where it would make sense to place the unregistration code is within a .handle_close() method, which is bypassed by the standard .handle_error() code.

I suggest switching to the self.handle_close() call at the end of handle_error() . Doing so preserves the passing of the test suite on release 2.5 on Windows.

[josiahcarlson]

I forgot to fix this in my most recent commits, but I'll fix it this
weekend for Python 2.6 .

[josiahcarlson]

Fixed for 2.6 in changelist 64768.
Fixed for 3.0 in changelist 64770.