StringIO.py clean-up.

[gminick]

BPO	822994
Nosy	@mwhudson, @loewis
Files	StringIO-closed.patch: StringIO.py clean-up.

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2003-10-18.10:21:38.000>
created_at = <Date 2003-10-13.19:47:15.000>
labels = ['library']
title = 'StringIO.py clean-up.'
updated_at = <Date 2003-10-18.10:21:38.000>
user = 'https://bugs.python.org/gminick'

bugs.python.org fields:

activity = <Date 2003-10-18.10:21:38.000>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2003-10-13.19:47:15.000>
creator = 'gminick'
dependencies = []
files = ['5626']
hgrepos = []
issue_num = 822994
keywords = ['patch']
message_count = 4.0
messages = ['44760', '44761', '44762', '44763']
nosy_count = 3.0
nosy_names = ['mwh', 'loewis', 'gminick']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue822994'
versions = ['Python 2.3']

[gminick]

Well, a one frequently used piece of code closed into function, self.closed returns
True/False instead of 1/0, self.softspace removed because it wasn't used. Sorry for
wasting your time if you don't treat it as a clean-up ;)

[mwhudson]

Logged In: YES
user_id=6656

softspace can be used, just not in this file. don't take it
out.

[gminick]

Logged In: YES
user_id=679226

Sorry, self.softspace is back again in the code. New patch attached.
Thank you for a comment, Michael.

[loewis]

Logged In: YES
user_id=21627

I found that isclosed is a bad function name: it is no
predicate (i.e. doesn't return bool), so I have renamed the
function, and committed the patch as StringIO.py 1.30.