Patch for bug #931877 Segfault in object_reduce_ex

[zseil]

BPO	1462488
Nosy	@birkenfeld
Files	typeobject_reduce.diff: Patch details.txt: explanation typeobject_reduce_2.diff: updated patch against trunk revision 54379

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2007-03-15.11:51:30.000>
created_at = <Date 2006-04-01.00:30:58.000>
labels = ['interpreter-core']
title = 'Patch for bug python/cpython#40129  Segfault in object_reduce_ex'
updated_at = <Date 2007-03-15.11:51:30.000>
user = 'https://bugs.python.org/zseil'

bugs.python.org fields:

activity = <Date 2007-03-15.11:51:30.000>
actor = 'zseil'
assignee = 'zseil'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2006-04-01.00:30:58.000>
creator = 'zseil'
dependencies = []
files = ['7123', '7124', '7125']
hgrepos = []
issue_num = 1462488
keywords = ['patch']
message_count = 5.0
messages = ['49916', '49917', '49918', '49919', '49920']
nosy_count = 2.0
nosy_names = ['georg.brandl', 'zseil']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1462488'
versions = []

[zseil]

This prevents unbounded recursion in typeobject.c's
object_reduce_ex(). It does so by splitting
implementation for object.__reduce_ex__ and
object.__reduce__ into two different C functions.
See the apended file details.txt for more detailed
explanation.

[birkenfeld]

I think this patch is fine, but you should include at least some of the detailed description as a comment for the new reduce method.

[zseil]

I would like to backport this patch to the 2.5 branch
so I made a new wersion that is fully backwards compatible
(well, except for the segfault :). Georg, could you please
take another look? And thanks for all the reviews, I can
hardly keep up :).
File Added: typeobject_reduce_2.diff

[birkenfeld]

Looks good to me -- as you say, there shouldn't be any behavioral differences.

[zseil]

Commited as revision 54397, 54398 (2.5).