Pickling exceptions crashes Python

[zseil]

BPO	1497319
Nosy	@birkenfeld
Files	test_exceptiontypes.py: unittests

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2006-05-30.08:35:23.000>
created_at = <Date 2006-05-30.05:29:12.000>
labels = ['interpreter-core']
title = 'Pickling exceptions crashes Python'
updated_at = <Date 2006-05-30.08:35:23.000>
user = 'https://bugs.python.org/zseil'

bugs.python.org fields:

activity = <Date 2006-05-30.08:35:23.000>
actor = 'zseil'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2006-05-30.05:29:12.000>
creator = 'zseil'
dependencies = []
files = ['2018']
hgrepos = []
issue_num = 1497319
keywords = []
message_count = 5.0
messages = ['28679', '28680', '28681', '28682', '28683']
nosy_count = 2.0
nosy_names = ['georg.brandl', 'zseil']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1497319'
versions = ['Python 2.5']

[zseil]

The crash happens if an Exception doesn't
have a dict, in BaseException_reduce.
Example:

Python 2.5a2 (trunk:46539M, May 30 2006, 05:02:24)
[MSC v.1310 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license"
for more information.
>>> import pickle
>>> e = BaseException()
>>> pickle.dumps(e) # crash

I'm attaching a module with this and some
other failing tests, mostly caused by
backward incompatibilities. All of the
tests pass on 2.5a2.

[birkenfeld]

Logged In: YES
user_id=849994

Thanks! Fixed in rev. 46551, added a test case.

[birkenfeld]

Logged In: YES
user_id=849994

Added another test for kw args in rev. 46553.

That args can only be an iterable and will, once assigned,
always be a tuple, was a decision we made.

[zseil]

Logged In: YES
user_id=1326842

The _PyArg_NoKeywords check should probably be in
BaseException_init, not in BaseException_new, so
that subclasses that want keyword arguments don't
have to override two methods.

[zseil]

Logged In: YES
user_id=1326842

Oh, and another thing, unpickling exceptions
that were pickled with an older version
of Python will have strange effects:

Python 2.4.3 (#69, Mar 29 2006, 17:35:34)
 ...
>>> import pickle
>>> f = open('jar', 'wb')
>>> e = Exception('cucumbers', 'cabbage')
>>> e.args
('cucumbers', 'cabbage')
>>> pickle.dump(e, f)
>>> f.close()
>>> f = open('jar', 'rb')
>>> e = pickle.load(f)
>>> f.close()
>>> e.args
('cucumbers', 'cabbage')

Python 2.5a2 (trunk:46539M, May 30 2006, 05:02:24)
  ...
>>> import pickle
>>> f = open('jar', 'rb')
>>> e = pickle.load(f)
>>> f.close()
>>> e.args
()
>>> e.__dict__['args']
('cucumbers', 'cabbage')