CGIHTTPServer doesn't handle path names with embeded space

[htgoebel]

BPO	1535504
Nosy	@akuchling, @birkenfeld, @devdanzin
Dependencies	bpo-1681674: subprocess.Popen fails with socket._fileobject on Windows
Files	CGIHTTPServer.patch: Patch for using subprocess against r54234

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2011-01-15.08:44:19.338>
created_at = <Date 2006-08-06.19:43:52.000>
labels = ['type-bug', 'library']
title = "CGIHTTPServer doesn't handle path names with embeded space"
updated_at = <Date 2011-01-15.08:44:19.329>
user = 'https://bugs.python.org/htgoebel'

bugs.python.org fields:

activity = <Date 2011-01-15.08:44:19.329>
actor = 'georg.brandl'
assignee = 'none'
closed = True
closed_date = <Date 2011-01-15.08:44:19.338>
closer = 'georg.brandl'
components = ['Library (Lib)']
creation = <Date 2006-08-06.19:43:52.000>
creator = 'htgoebel'
dependencies = ['1681674']
files = ['7453']
hgrepos = []
issue_num = 1535504
keywords = ['patch']
message_count = 11.0
messages = ['50837', '50838', '50839', '50840', '50841', '50842', '50843', '83902', '114813', '126310', '126318']
nosy_count = 6.0
nosy_names = ['akuchling', 'georg.brandl', 'htgoebel', 'ajaksu2', 'BreamoreBoy', 'rosslagerwall']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = 'test needed'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1535504'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

[htgoebel]

This is a patch for Bug bpo-1436206:

On Windows, if the path name of a CGI script to be run
contains space characters, it need to be quoted
properly when called via os.popen2/3. Otherwise the
script can not be executed.

Solved by using commands.mkarg() to quote arguments
where necessary.

[akuchling]

Logged In: YES
user_id=11375

Would it simplify matters if CGIHTTPServer used the
subprocess module, which tries to provide a
platform-independent interface?

[birkenfeld]

Note that commands.mkarg() is written for UNIX shells. While it may work with spaces in the file name, it may produce illegal Windows command line commands in other cases.

[htgoebel]

I think the best way to solve this would be to use the
subprocess module, as amk suggested.

I included a new patch which for CGIHTTPServer which uses subprocess. Unfortunately
this does not work ion Windows due to a problem with subprocess: On Windows
passing the request.rfile (a _fileobject wrapper arround the socket) as stdin/out
lead to an error. I'll file a bugreport on that case.

Beside of this, the patch should solve the problem in a platform-independent way.
File Added: CGIHTTPServer.patch

[birkenfeld]

Which error is that? Is it perhaps this: http://python.org/sf/1124861 ?

[htgoebel]

No, the error it's related to http://python.org/sf/1175984 (and maybe http://python.org/sf/1260171).

[htgoebel]

The bugreport I spoke of has been filed as http://python.org/sf/1681674.

[devdanzin]

bpo-1681674 was closed as won't fix, so IIUC this patch won't work.

[BreamoreBoy]

A patch that includes unit tests and doc changes is presumably needed to take this forward.

[rosslagerwall]

Shouldn't this be closed? CGIHTTPServer *has* been updated to use subprocess on windows and the dependency has been closed as wont fix.

[birkenfeld]

Right, closing this one too. Thanks!