smtplib SMTP_SSL._get_socket doesn't return a value

[marcinbachry]

BPO	4066
Nosy	@devdanzin, @bitdancer
Files	smtplib.diff: simple fix smtplib_72551.diff: updated _get_socket to return value, expected behavior. test_smtpnet.py: simplified test from python/issues-test-cpython#4470 return_socket.diff: Farhan's patch and Marcin's test adapted to py3k.

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2009-05-23.02:53:34.676>
created_at = <Date 2008-10-07.14:26:15.273>
labels = ['type-bug', 'library']
title = "smtplib SMTP_SSL._get_socket doesn't return a value"
updated_at = <Date 2009-05-23.02:53:34.559>
user = 'https://bugs.python.org/marcinbachry'

bugs.python.org fields:

activity = <Date 2009-05-23.02:53:34.559>
actor = 'r.david.murray'
assignee = 'none'
closed = True
closed_date = <Date 2009-05-23.02:53:34.676>
closer = 'r.david.murray'
components = ['Library (Lib)']
creation = <Date 2008-10-07.14:26:15.273>
creator = 'marcin.bachry'
dependencies = []
files = ['11729', '13949', '13952', '13964']
hgrepos = []
issue_num = 4066
keywords = ['patch']
message_count = 7.0
messages = ['74452', '87537', '87541', '87549', '87552', '87598', '88221']
nosy_count = 5.0
nosy_names = ['ajaksu2', 'farhan.ahmad', 'marcin.bachry', 'r.david.murray', 'fanda.vacek']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue4066'
versions = ['Python 2.6', 'Python 3.0', 'Python 3.1', 'Python 2.7']

[marcinbachry]

SMTP.connect method expects _get_socket() method to return socket object:

  self.sock = self._get_socket(host, port, self.timeout)

but overriden _get_socket() method in SMTP_SSL class doesnt' have return
statement (it sets self.sock instead). Hence I get
SMTPServerDisconnected exception when I try to send mail over ssl.

The same seems to apply to LMTP class.

[farhanahmad]

Marcin, thanks for finding the cause. I have attached another diff
that, instead of removing the assignment, makes the _get_socket function
return the socket, which is the expected behavior.

You mentioned that the LMTP class also has this issue. I looked through
that class, but didn't see any similar issues. Can you please give more
details?

Thanks,
Farhan

[marcinbachry]

Your diff is better than mine and looks quite similar to patch number 2
in bpo-4470. If the whole bpo-4470 can't be accepted for now, we could at
least apply this one change, because without it SMTP_SSL is totally
unusable. Daniel, maybe we can mark this bug or bpo-4470 as critical?

LMTP seems ok indeed; I don't remember why I mentioned it. :)

[devdanzin]

Marcin,
Done and set this one as a dependency of 4470. It would be very good to
have a test that flexes this patch, can you work on one?

[marcinbachry]

Here's a dumbed down version of the test from bpo-4470. It requires
network, but no gmail account is needed to run the test.

[devdanzin]

Thanks, Marcin!

Same bug seems to apply to py3k, ported patches attached.

[bitdancer]

Applied to trunk in r72835, with some test fixes after (to skip the test
if SSL isn't installed). Applied to py3k in r72836, ditto on fixes. I
also backported the fix and test to 26-maint and 30-maint.