patches for Modules/socketmodule.c for NetBSD

[yesmar]

BPO	5510
Nosy	@gpshead, @giampaolo, @merwok, @0-wiz-0
Files	Python-2.6.1.patch netbsd.patch netbsd-wizs-mod.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gpshead'
closed_at = <Date 2010-10-17.00:44:09.763>
created_at = <Date 2009-03-18.18:21:30.590>
labels = ['build']
title = 'patches for Modules/socketmodule.c for NetBSD'
updated_at = <Date 2010-10-17.00:44:09.761>
user = 'https://bugs.python.org/yesmar'

bugs.python.org fields:

activity = <Date 2010-10-17.00:44:09.761>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2010-10-17.00:44:09.763>
closer = 'gregory.p.smith'
components = ['Build']
creation = <Date 2009-03-18.18:21:30.590>
creator = 'yesmar'
dependencies = []
files = ['13366', '15235', '18326']
hgrepos = []
issue_num = 5510
keywords = ['patch']
message_count = 6.0
messages = ['83767', '94729', '112235', '112422', '112500', '118910']
nosy_count = 6.0
nosy_names = ['gregory.p.smith', 'giampaolo.rodola', 'eric.araujo', 'aniou', 'yesmar', 'wiz']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue5510'
versions = ['Python 3.2']

[yesmar]

I couldn't install setuptools (required by gitosis) because Python 2.6.1
didn't install socket when I built it. A little digging and I
uncommented the "_socket socketmodule.c" line in Modules/Setup.
Unfortunately, the Bluetooth socket stuff in Modules/socketmodule.c was
broken under NetBSD. I made this patch and tested on NetBSD 4.0.1.

When researching this bug on bugs.python.org, I noticed bpo-5400 which,
in order to get Modules/socketmodule.c compiling, disabled Bluetooth
socket support entirely. That isn't necessary. I just had to ensure the
various structure references made use of the proper member names
(according to NetBSD's /usr/include/netbt/bluetooth.h header file). The
changes I made were similar, though not precisely the same, as those for
FreeBSD.

After patching and building:

ramsey@wizard /opt/build/runtime/Python-2.6.1$ ./python -bb -E
Lib/test/regrtest.py test_socket
test_socket
1 test OK.

[0-wiz-0]

Attached is the patch fixing this problem from pkgsrc; it was written by
Iain Hibbert <plunky@NetBSD.org> who also maintains BlueTooth in NetBSD,
so I'm very confident it's "right" :)

Please include it!

[merwok]

Does the bug still exist in 3.2 (branch named py3k in subversion)? Do the patch still apply? (The workflow is to patch the version in development and then backport fixes to stable branches.)

Adding Giampaolo to nosy since he’s listed as interested in networking in Misc/maintainers.rst

[yesmar]

I don't know. I switched to Linux from NetBSD and I don't use Python
for anything anymore.

On Jul 31, 2010, at 5:27 PM, Éric Araujo wrote:

Éric Araujo <merwok@netwok.org> added the comment:

Does the bug still exist in 3.2 (branch named py3k in subversion)?
Do the patch still apply? (The workflow is to patch the version in
development and then backport fixes to stable branches.)

Adding Giampaolo to nosy since he’s listed as interested in
networking in Misc/maintainers.rst

----------
nosy: +giampaolo.rodola, merwok
versions: +Python 3.2 -Python 2.6

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue5510\>

---

~/Ramsey

"Civilized men are more discourteous than savages because they know
they can be impolite without having their skulls split, as a general
thing."
-- Robert E. Howard, "Tower of the Elephant"

[aniou]

On Sun, Aug 01, 2010 at 12:27:50AM +0000, Éric Araujo wrote:

Éric Araujo <merwok@netwok.org> added the comment:

Does the bug still exist in 3.2 (branch named py3k in subversion)? Do
the patch still apply? (The workflow is to patch the version in
development and then backport fixes to stable branches.)

As far I see - yes, py3k still needs patch provided by wiz, even on
NetBSD 5.1 (current RC stable). Oryginal diff doesn't apply, I made
some amateur changes and "my" version of wiz's patch is in attachment.

But we have another problem, use sem_timedwait in Python/thread_pthread.h

• not directly connected with this case, but prevent py3k from build.
  I copy some lines from Modules/_multiprocessing/semaphore.c, but this is
  very ugly workaround and someone should look at this...

[gpshead]

netbsd-wizs-mod.patch applied in 85587.