asynchronous connect in asyncore.dispatcher does not set addr

[anacrolix]

BPO	13694
Nosy	@akuchling, @josiahcarlson, @giampaolo, @anacrolix
Files	dispatcher_connect_addr.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-03-20.15:51:39.893>
created_at = <Date 2012-01-02.02:15:15.573>
labels = ['type-bug', 'library']
title = 'asynchronous connect in asyncore.dispatcher does not set addr'
updated_at = <Date 2012-03-20.15:51:39.892>
user = 'https://github.com/anacrolix'

bugs.python.org fields:

activity = <Date 2012-03-20.15:51:39.892>
actor = 'giampaolo.rodola'
assignee = 'none'
closed = True
closed_date = <Date 2012-03-20.15:51:39.893>
closer = 'giampaolo.rodola'
components = ['Library (Lib)']
creation = <Date 2012-01-02.02:15:15.573>
creator = 'anacrolix'
dependencies = []
files = ['24124']
hgrepos = []
issue_num = 13694
keywords = ['patch']
message_count = 9.0
messages = ['150449', '150455', '150487', '155914', '156414', '156421', '156422', '156423', '156424']
nosy_count = 7.0
nosy_names = ['akuchling', 'josiahcarlson', 'giampaolo.rodola', 'stutzbach', 'anacrolix', 'rosslagerwall', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue13694'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[anacrolix]

Patch attached

[giampaolo]

I'm not sure how useful this is as addr will be set later, when connection is established.

[anacrolix]

I don't believe it is. dispatcher.addr is only set if the connection is immediately established. It's set explicitly in dispatcher.__init__ if a socket is provided that is already connected. It's *not* set after a connection completes.

There are 2 solutions as I see it:

1. Set addr after a successful call to socket.connect indicates that a connection is being established. Currently this only occurs if the connection is not delayed.
2. Set the addr when a connect event completes. This would require making getpeername calls like in dispatcher.__init__ and would be significantly more expensive.

My patch implements method 1. This conforms to existing addr-setting behaviour in dispatcher.bind.

[anacrolix]

I should mention that this failure to set addr is unusual seeing as most socket instances are wrapping AF_INET* domain sockets, and aren't likely to connect without blocking. This is quite likely a reason nobody has observed it until now.

It *is* desirable to save addr at this point, as mentioned in previous comments.

Additionally addr is public API insofar as asyncore.sockets are concerned.

[anacrolix]

This patch is a shoo-in, can someone review and commit this?

[python-dev]

New changeset 1c0058991740 by Giampaolo Rodola' in branch 'default':
Fix issue bpo-13694: asynchronous connect in asyncore.dispatcher does not set addr.
http://hg.python.org/cpython/rev/1c0058991740

[python-dev]

New changeset 4e5ddde76dbe by Giampaolo Rodola' in branch '2.7':
Fix issue bpo-13694: asynchronous connect in asyncore.dispatcher does not set addr.
http://hg.python.org/cpython/rev/4e5ddde76dbe

[python-dev]

New changeset a5add01e96be by Giampaolo Rodola' in branch '3.2':
Fix issue bpo-13694: asynchronous connect in asyncore.dispatcher does not set addr.
http://hg.python.org/cpython/rev/a5add01e96be

[giampaolo]

Done. Sorry for the delay.