Incorrect documentation for socket.py on linux

[ShaneHansen]

BPO	14303
Nosy	@birkenfeld, @pitrou, @ericsnowcurrently
Files	test.py: script which asserts that dup() was called and the object returned by makefile has a different fileno() than the socket.

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-10-06.14:37:04.215>
created_at = <Date 2012-03-14.16:58:17.564>
labels = ['type-bug', 'expert-IO', 'docs']
title = 'Incorrect documentation for socket.py on linux'
updated_at = <Date 2014-10-06.14:37:04.213>
user = 'https://bugs.python.org/ShaneHansen'

bugs.python.org fields:

activity = <Date 2014-10-06.14:37:04.213>
actor = 'python-dev'
assignee = 'docs@python'
closed = True
closed_date = <Date 2014-10-06.14:37:04.215>
closer = 'python-dev'
components = ['Documentation', 'IO']
creation = <Date 2012-03-14.16:58:17.564>
creator = 'Shane.Hansen'
dependencies = []
files = ['24843']
hgrepos = []
issue_num = 14303
keywords = []
message_count = 3.0
messages = ['155768', '228592', '228697']
nosy_count = 7.0
nosy_names = ['georg.brandl', 'pitrou', 'docs@python', 'BreamoreBoy', 'python-dev', 'eric.snow', 'Shane.Hansen']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue14303'
versions = ['Python 2.7']

[ShaneHansen]

The python docs state that for socket.makefile "The file object references a dup()ped version of the socket file descriptor, so the file object and socket object may be closed or garbage-collected independently."

In fact for socket.py dup() is never called, and no additional files are opened. Instead an object is returned which uses the original socket and does buffering.

For me, this is the desired behaviour, but just thought I'd mention the docs were off.

[BreamoreBoy]

Shane, there are major differences between the makefile docs versions 2 and 3, so could you prepare a patch for this addressed at version 2 only?

[python-dev]

New changeset 6e2a72e05b4f by Georg Brandl in branch '2.7':
Closes bpo-14303: socket.makefile() does not call dup() anymore on the socket fd.
https://hg.python.org/cpython/rev/6e2a72e05b4f