Solaris compiler chokes on importlib.h

[pitrou]

BPO	15103
Nosy	@birkenfeld, @jcea, @pitrou, @serhiy-storchaka

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-06-19.14:39:59.483>
created_at = <Date 2012-06-18.21:38:00.816>
labels = ['interpreter-core', 'build']
title = 'Solaris compiler chokes on importlib.h'
updated_at = <Date 2012-06-19.15:00:34.731>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2012-06-19.15:00:34.731>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2012-06-19.14:39:59.483>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2012-06-18.21:38:00.816>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 15103
keywords = []
message_count = 8.0
messages = ['163124', '163131', '163153', '163167', '163171', '163172', '163174', '163175']
nosy_count = 6.0
nosy_names = ['georg.brandl', 'jcea', 'pitrou', 'python-dev', 'serhiy.storchaka', 'Justin.Venus']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue15103'
versions = ['Python 3.3']

[pitrou]

The Solaris compiler chokes on the embedded NUL character. Perhaps we can find another way to remove the importlib.h diffs from the notification e-mails (simply hardcode the filename?).

http://www.python.org/dev/buildbot/all/builders/x86%20Solaris%2011%203.x/builds/21/steps/compile/logs/stdio

/opt/solarisstudio/bin/cc -c -O -I. -I./Include -DPy_BUILD_CORE -o Python/frozen.o Python/frozen.c
"Python/importlib.h", line 3847: null character in input
cc: acomp failed for Python/frozen.c

[JustinVenus]

What is the purpose of the comment at the end of "Python/importlib.h"? If I remove the comment that states "binary marker for mercurial" (something to that effect anyhow) the code compiles and only the tests fail.

[pitrou]

What is the purpose of the comment at the end of "Python/importlib.h"?

The purpose is to include a NUL character in the source file so that Mercurial treats this (generated) file as a binary file, and so that the diffs are omitted in commit notification e-mails.
Since this does not seem to ve valid C (or is it?), we will have to find something else, I think.

[serhiy-storchaka]

It looks as great disadvantage compared with Subversion.

There are several ways to solve this problem:

1. Python/freeze_importlib.py generates a raw binary file Python/importlib.dump (just marshal dump) and this file is placed in the repository. Then a small C program Python/unpack_importlib.c (or something of the sort) is compiled and converts the file Python/importlib.dump in the file Python/importlib.h.

2. Python/freeze_importlib.py generates a header file Python/importlib.h.in with binary marker as now and this binary file is placed in the repository. Then on Posix systems Python/importlib.h.in is converted to Python/importlib.h by deleting binary marker (tr -d '\0') or whole line with binary marker (head/tail/sed/grep/awk). On Windows Python/importlib.h.in is just copied to Python/importlib.h.

[python-dev]

New changeset 7d86e207598f by Antoine Pitrou in branch 'default':
Issue bpo-15103: remove the NUL character (serving as a Mercurial binary marker) from Python/importlib.h.
http://hg.python.org/cpython/rev/7d86e207598f

[pitrou]

This should be fixed now.

[jcea]

As a general rule, generated files should not be included in the repository.

Recent mercurial versions include a "--large" parameter for "hg add" that threat files as binary. In particular, precludes "hg diff", that I guess it is the point here.

[pitrou]

As a general rule, generated files should not be included in the
repository.

We already include generated files such as configure. This is either for
convenience or for bootstrap purposes.

Recent mercurial versions include a "--large" parameter for "hg add"
that threat files as binary.

No, it has nothing to do. "--large" is added by the largefiles
extension.