Updating __sizeof__ tests

[serhiy-storchaka]

BPO	15467
Nosy	@loewis, @birkenfeld, @meadori, @serhiy-storchaka
Files	sizeof_tests-3.3_2.patch: Patch for 3.3 sizeof_tests-3.2_2.patch: Patch for 3.2 sizeof_tests-2.7_2.patch: Patch for 2.7

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-07-29.14:40:04.608>
created_at = <Date 2012-07-27.15:33:45.278>
labels = ['type-bug', 'tests']
title = 'Updating __sizeof__ tests'
updated_at = <Date 2012-07-29.15:47:55.519>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2012-07-29.15:47:55.519>
actor = 'meador.inge'
assignee = 'none'
closed = True
closed_date = <Date 2012-07-29.14:40:04.608>
closer = 'loewis'
components = ['Tests']
creation = <Date 2012-07-27.15:33:45.278>
creator = 'serhiy.storchaka'
dependencies = []
files = ['26561', '26562', '26563']
hgrepos = []
issue_num = 15467
keywords = ['patch']
message_count = 9.0
messages = ['166574', '166580', '166599', '166604', '166659', '166721', '166766', '166767', '166768']
nosy_count = 5.0
nosy_names = ['loewis', 'georg.brandl', 'meador.inge', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue15467'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

[serhiy-storchaka]

The proposed patches move to test.support some functions, which will be useful for testing __sizeof__. The next few patches will use it. Also in 3.3 some bugs have fixed, now "n" is used for Py_ssize_t and Py_hash_t (which is not long now).

[loewis]

The problem is that this adds new features to test_support, which can only be done in 3.4.

[serhiy-storchaka]

Can we get around this by renaming check_sizeof into _check_sizeof? Or would
we have to duplicate these auxiliary functions in every test file with
__sizeof__ test?

[loewis]

Not sure: that's for release managers to decide.

[serhiy-storchaka]

I asked in Python-Dev, and if I understood the answers correctly, we can make changes to 2.7 and 3.2 without fear. For 3.3 risk is higher, so we need to be more attentive. However patch for 3.3 contains not only the potential improvements for other tests, but also bug fixes (I think these bugs should cause tests failure on the platforms where sizeof(Py_ssize_t) != sizeof(long) or sizeof(Py_ssize_t) != sizeof(void*)).

Of cause, if Georg Brandl not vetoes this.

[serhiy-storchaka]

Patches updated. Simplified struct __sizeof__ testing for 2.7 and 3.2 and fixed (using 'n' for Py_ssize_t) for 3.3.

[python-dev]

New changeset efade142ef01 by Martin v. Löwis in branch '3.2':
Issue bpo-15467: Move helpers for __sizeof__ tests into test_support.
http://hg.python.org/cpython/rev/efade142ef01

New changeset d43ff8eb4cb3 by Martin v. Löwis in branch 'default':
Issue bpo-15467: Merge 3.2
http://hg.python.org/cpython/rev/d43ff8eb4cb3

[python-dev]

New changeset fa95b04e67fd by Martin v. Löwis in branch '2.7':
Issue bpo-15467: Move helpers for __sizeof__ tests into test_support.
http://hg.python.org/cpython/rev/fa95b04e67fd

[loewis]

I wasn't aware that test_support isn't public API. The patches are fine then; committed.