test_importlib: test_locks failure

[skrah]

BPO	15794
Nosy	@brettcannon, @birkenfeld, @ncoghlan, @pitrou, @vstinner, @tiran, @skrah, @ericsnowcurrently
Files	relax_deadlock_test.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-08-28.18:14:47.480>
created_at = <Date 2012-08-27.22:35:01.396>
labels = ['type-bug', 'tests']
title = 'test_importlib: test_locks failure'
updated_at = <Date 2012-08-28.18:14:47.480>
user = 'https://github.com/skrah'

bugs.python.org fields:

activity = <Date 2012-08-28.18:14:47.480>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2012-08-28.18:14:47.480>
closer = 'pitrou'
components = ['Tests']
creation = <Date 2012-08-27.22:35:01.396>
creator = 'skrah'
dependencies = []
files = ['27025']
hgrepos = []
issue_num = 15794
keywords = ['patch']
message_count = 5.0
messages = ['169232', '169238', '169239', '169257', '169290']
nosy_count = 9.0
nosy_names = ['brett.cannon', 'georg.brandl', 'ncoghlan', 'pitrou', 'vstinner', 'christian.heimes', 'skrah', 'python-dev', 'eric.snow']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue15794'
versions = ['Python 3.3', 'Python 3.4']

[skrah]

On the obstinate i7 machine (see bpo-15781), test_importlib fails
sporadically (after 10 repetitions or so).

$ ./python -m test -uall -F test_importlib                                                               
[  1] test_importlib                                                                                     
test test_importlib failed -- Traceback (most recent call last):                                         
  File "/home/stefan/hg/cpython/Lib/test/test_importlib/test_locks.py", line 80, in test_deadlock        
    self.assertEqual(results.count((True, False)), 1)                                                    
AssertionError: 2 != 1                                                                                   
                                                                                                         
1 test failed:                                                                                           
    test_importlib

[skrah]

Also reproduced on Ubuntu Lucid/Core 2 Duo with a very low switch
interval and -j4. It takes more repetitions than on the i7:

$ ./python -m test -uall -F -j4  test_importlib 
[...]
[224] test_importlib
[225] test_importlib
[226/1] test_importlib
test test_importlib failed -- Traceback (most recent call last):
  File "/home/stefan/pydev/cpython/Lib/test/test_importlib/test_locks.py", line 80, in test_deadlock
    self.assertEqual(results.count((True, False)), 1)
AssertionError: 2 != 1

[pitrou]

After a bit of investigation, it turns out the test is probably too strict.
The deadlock avoidance logic in importlib._bootstrap is indeed conservative: if you take a look at _ModuleLock.acquire(), _blocking_on[tid] is set even while other threads may run, because the internal lock is not always taken. Therefore, if there's a potential deadlock between several threads, there are situations where DeadlockError will be raised in two threads, not only one.

(IMHO it would complicate the code too much to make deadlock avoidance less conservative, without bringing anything in terms of additional functionality)

See attached patch.

[skrah]

The patch works fine here (as expected).

[python-dev]

New changeset 454dceb5fd56 by Antoine Pitrou in branch 'default':
Issue bpo-15794: Relax a test case due to the deadlock detection's conservativeness.
http://hg.python.org/cpython/rev/454dceb5fd56