Memory leak in PyUnicode_TranslateCharmap()

[tiran]

BPO	15900
Nosy	@birkenfeld, @jcea, @tiran
Files	translate_leak.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2012-09-22.07:24:45.582>
created_at = <Date 2012-09-10.09:58:22.021>
labels = ['interpreter-core', 'performance']
title = 'Memory leak in PyUnicode_TranslateCharmap()'
updated_at = <Date 2012-09-24.05:46:45.790>
user = 'https://github.com/tiran'

bugs.python.org fields:

activity = <Date 2012-09-24.05:46:45.790>
actor = 'python-dev'
assignee = 'georg.brandl'
closed = True
closed_date = <Date 2012-09-22.07:24:45.582>
closer = 'georg.brandl'
components = ['Interpreter Core']
creation = <Date 2012-09-10.09:58:22.021>
creator = 'christian.heimes'
dependencies = []
files = ['27164']
hgrepos = []
issue_num = 15900
keywords = ['patch', '3.3regression']
message_count = 6.0
messages = ['170170', '170211', '170293', '170294', '170964', '171095']
nosy_count = 4.0
nosy_names = ['georg.brandl', 'jcea', 'christian.heimes', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue15900'
versions = ['Python 3.3', 'Python 3.4']

[tiran]

Objects/unicodeobject.c:PyUnicode_TranslateCharmap() leaks a reference to the variable unicode. PyUnicode_Translate() is also implemented around the helper function _PyUnicode_TranslateCharmap() but it properly decrefs the reference to the first argument.

PyUnicode_Translate() also has an obsolete onError goto label. The patch fixes the leak and simplifies PyUnicode_Translate().

CID 719686

[jcea]

Looks good to me. Are 2.7/3.2 not affected?.

Christian, Please, commit the patch and notify Georg for 3.3.0 inclusion.

[python-dev]

New changeset 4f2811e5e462 by Christian Heimes in branch 'default':
Issue bpo-15900: Fixed reference leak in PyUnicode_TranslateCharmap()
http://hg.python.org/cpython/rev/4f2811e5e462

[tiran]

Yes, 3.2 and earlier are not affected.

Georg, I'm assigning the bug to you so you can decide if you like to cherry pick the fix.

[birkenfeld]

Done as 89f62f143920.

[python-dev]

New changeset 89f62f143920 by Christian Heimes in branch 'default':
Issue bpo-15900: Fixed reference leak in PyUnicode_TranslateCharmap()
http://hg.python.org/cpython/rev/89f62f143920