pyexpat: Argument for UseForeignDTD should be optional

[eseifert]

BPO	16012
Nosy	@birkenfeld, @pitrou, @tiran, @benjaminp, @ezio-melotti
Files	issue16012.patch issue16012_py32.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2012-09-24.11:42:17.911>
created_at = <Date 2012-09-24.10:10:04.589>
labels = ['extension-modules', 'type-bug', 'release-blocker']
title = 'pyexpat: Argument for UseForeignDTD should be optional'
updated_at = <Date 2012-09-29.07:27:39.258>
user = 'https://bugs.python.org/eseifert'

bugs.python.org fields:

activity = <Date 2012-09-29.07:27:39.258>
actor = 'python-dev'
assignee = 'georg.brandl'
closed = True
closed_date = <Date 2012-09-24.11:42:17.911>
closer = 'georg.brandl'
components = ['Extension Modules']
creation = <Date 2012-09-24.10:10:04.589>
creator = 'eseifert'
dependencies = []
files = ['27274', '27275']
hgrepos = []
issue_num = 16012
keywords = ['patch', '3.2regression', '3.3regression']
message_count = 10.0
messages = ['171108', '171110', '171111', '171112', '171113', '171115', '171118', '171119', '171120', '171555']
nosy_count = 7.0
nosy_names = ['georg.brandl', 'pitrou', 'christian.heimes', 'benjamin.peterson', 'ezio.melotti', 'python-dev', 'eseifert']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue16012'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

[eseifert]

It seems the recent changes to Modules/pyexpat.c made the boolean 'flag' for UseForeignDTD mandatory although it was optional in previous Python releases.

According to the docs the usage is UseForeignDTD([flag]), but calling UseForeignDTD without arguments leads to an error::

  >>> from xml.parsers import expat
  >>> parser = expat.ParserCreate('utf8')
  >>> parser.UseForeignDTD()
  Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
  TypeError: UseForeignDTD() takes exactly 1 argument (0 given)

This was tested with version bfdf366a779a from hg repository.

[tiran]

Confirmed!

In Ubuntu's Python 2.7.3 and 3.2.3 UseForeignDTD() can be called without an argument. The hg versions of 2.7, 3.2 and 3.3 require one argument. The change smells like a regression for all affected Python versions.

Antoine, it looks like you committed the modification.

[ezio-melotti]

This seems to be the changeset that introduced the regression b878df1d23b1.

[tiran]

I've created a patch with a simple test case.

[pitrou]

Ah, that's true. Too bad it wasn't tested for :(

[tiran]

Don't feel bad. The final hasn't been released yet. :)

Here is a slightly different patch for 3.2 and 2.7.

[python-dev]

New changeset 22ddf77e0497 by Christian Heimes in branch '3.2':
Issue bpo-16012: Fix a regression in pyexpat. The parser's UseForeignDTD()
http://hg.python.org/cpython/rev/22ddf77e0497

New changeset 3e0d632ce910 by Christian Heimes in branch '2.7':
Issue bpo-16012: Fix a regression in pyexpat. The parser's UseForeignDTD()
http://hg.python.org/cpython/rev/3e0d632ce910

New changeset 0f55ad9b07c8 by Christian Heimes in branch 'default':
Issue bpo-16012: Fix a regression in pyexpat. The parser's UseForeignDTD()
http://hg.python.org/cpython/rev/0f55ad9b07c8

[tiran]

Erich, thank you very much for your bug report. Your report made it right in time for the upcoming 3.3.0 final release.

Here you are, Georg.

[birkenfeld]

Fixed in release clone as b907f99272c5.

[python-dev]

New changeset b907f99272c5 by Georg Brandl in branch 'default':
Port bpo-16012 fix: parameter parsing regression in pyexpat parser UseForeignDTD() method.
http://hg.python.org/cpython/rev/b907f99272c5