shutil.make_archive() doesn't use its "verbose" argument

[birkenfeld]

BPO	22771
Nosy	@akuchling, @birkenfeld, @berkerpeksag

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2014-10-31.09:54:25.677>
created_at = <Date 2014-10-31.08:54:21.232>
labels = ['library']
title = 'shutil.make_archive() doesn\'t use its "verbose" argument'
updated_at = <Date 2014-10-31.09:54:25.675>
user = 'https://github.com/birkenfeld'

bugs.python.org fields:

activity = <Date 2014-10-31.09:54:25.675>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-10-31.09:54:25.677>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2014-10-31.08:54:21.232>
creator = 'georg.brandl'
dependencies = []
files = []
hgrepos = []
issue_num = 22771
keywords = []
message_count = 4.0
messages = ['230324', '230329', '230330', '230331']
nosy_count = 4.0
nosy_names = ['akuchling', 'georg.brandl', 'python-dev', 'berker.peksag']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue22771'
versions = ['Python 3.4', 'Python 3.5']

[birkenfeld]

It seems like "verbose" should be passed to the archival function, but it isn't.

[berkerpeksag]

"verbose" was used by _call_external_zip() (see https://hg.python.org/cpython/rev/a1d078b88247#l3.143), and _call_external_zip() was removed in bpo-20744 (see https://hg.python.org/cpython/rev/681e20f8b717).

Perhaps we can deprecate "version" arguments of make_archive and _make_* functions.

[birkenfeld]

That makes sense.

[python-dev]

New changeset 335ff0c6d879 by Georg Brandl in branch '3.4':
Closes bpo-22771: "verbose" is unused; deprecate it.
https://hg.python.org/cpython/rev/335ff0c6d879