Fix mkdir() call for Watcom compilers on UNIX-like platforms

[JeffreyArmstrong]

BPO	23876
Files	watcom_qnx_to_unix-3.5.0a3.patch: Minor patch changing macros only on Watcom compilers

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-08-04.18:01:00.593>
created_at = <Date 2015-04-06.12:41:15.475>
labels = ['interpreter-core', 'build']
title = 'Fix mkdir() call for Watcom compilers on UNIX-like platforms'
updated_at = <Date 2018-08-04.18:01:00.593>
user = 'https://bugs.python.org/JeffreyArmstrong'

bugs.python.org fields:

activity = <Date 2018-08-04.18:01:00.593>
actor = 'Jeffrey.Armstrong'
assignee = 'none'
closed = True
closed_date = <Date 2018-08-04.18:01:00.593>
closer = 'Jeffrey.Armstrong'
components = ['Interpreter Core']
creation = <Date 2015-04-06.12:41:15.475>
creator = 'Jeffrey.Armstrong'
dependencies = []
files = ['38843']
hgrepos = []
issue_num = 23876
keywords = ['patch']
message_count = 1.0
messages = ['240153']
nosy_count = 1.0
nosy_names = ['Jeffrey.Armstrong']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue23876'
versions = ['Python 3.5']

[JeffreyArmstrong]

Within Modules/posixmodule.c:4914 (in 3.5.0a3), the preprocessor checks for compiler macros as such:

#if ( defined(__WATCOMC__) || defined(PYCC_VACPP) ) && !defined(__QNX__)
        result = mkdir(path->narrow);
#else
        result = mkdir(path->narrow, mode);
#endif

The purpose of the code was to detect if we're compiling using Watcom, but not on QNX, or VisualAge as our compiler, where mkdir() wouldn't accept a mode. However, Watcom supports Linux as well and properly implements the mode argument, causing the compilation to fail.

The proper check, rather than looking for "!defined(QNX)" would be "!defined(UNIX)," which would allow the code to properly compile using Watcom on either Linux or QNX:

#if ( defined(__WATCOMC__) || defined(PYCC_VACPP) ) && !defined(__UNIX__)
        result = mkdir(path->narrow);
#else
        result = mkdir(path->narrow, mode);
#endif

FYI, in Watcom, the __UNIX__ macro is defined on both Linux and QNX, so this change will not break code for people who are still using Watcom to build Python for QNX (which is probably nobody at all).

There are two other places where the __QNX__ macro should be replaced in Modules/posixmodule.c, and the attached patch fixes both.