Some unittest loader tests are silently skipped by mistake

[serhiy-storchaka]

BPO	27063
Nosy	@rbtcollins, @ezio-melotti, @voidspace, @berkerpeksag, @serhiy-storchaka
Files	test_loader.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-05-20.20:55:49.560>
created_at = <Date 2016-05-19.20:31:11.963>
labels = ['type-bug', 'tests']
title = 'Some unittest loader tests are silently skipped by mistake'
updated_at = <Date 2016-05-20.20:55:49.558>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2016-05-20.20:55:49.558>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2016-05-20.20:55:49.560>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2016-05-19.20:31:11.963>
creator = 'serhiy.storchaka'
dependencies = []
files = ['42905']
hgrepos = []
issue_num = 27063
keywords = ['patch']
message_count = 5.0
messages = ['265894', '265957', '265958', '265959', '265960']
nosy_count = 6.0
nosy_names = ['rbcollins', 'ezio.melotti', 'michael.foord', 'python-dev', 'berker.peksag', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue27063'
versions = ['Python 3.5', 'Python 3.6']

[serhiy-storchaka]

Due to bug in the decorator some tests in Lib/unittest/test/test_loader.py are silently skipped. Proposed patch fixes this as well as other bugs in the decorator and tests.

[berkerpeksag]

LGTM. Just curious, did you find it by reading code or by using some tool?

[rbtcollins]

LGTM too

[python-dev]

New changeset e715ffd2d938 by Serhiy Storchaka in branch '3.5':
Issue bpo-27063: Some unittest loader tests were silently skipped.
https://hg.python.org/cpython/rev/e715ffd2d938

New changeset f4f615edb6b1 by Serhiy Storchaka in branch 'default':
Issue bpo-27063: Some unittest loader tests were silently skipped.
https://hg.python.org/cpython/rev/f4f615edb6b1

[serhiy-storchaka]

Thank you for review.

I found this when wrote patches for removing deprecated features.