Add Lib/test/__main__.py in 2.7

[serhiy-storchaka]

BPO	30223
Nosy	@ncoghlan, @vstinner, @ezio-melotti, @zware, @serhiy-storchaka, @zhangyangyu
PRs	[2.7] bpo-30223: Add Lib/test/__main__.py. #1373 [2.7] bpo-30223: Fix test_xpickle for Python 2.4. #1395 [2.7] bpo-30223: Add global in regrtest main_in_temp_cwd #1399

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-05-05.16:21:10.245>
created_at = <Date 2017-05-02.06:56:55.910>
labels = ['type-feature', 'tests']
title = 'Add Lib/test/__main__.py in 2.7'
updated_at = <Date 2017-05-05.16:21:10.244>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2017-05-05.16:21:10.244>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2017-05-05.16:21:10.245>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2017-05-02.06:56:55.910>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 30223
keywords = []
message_count = 15.0
messages = ['292720', '292722', '292723', '292735', '292779', '292786', '292794', '292795', '292796', '292797', '292798', '292808', '292811', '292814', '293119']
nosy_count = 6.0
nosy_names = ['ncoghlan', 'vstinner', 'ezio.melotti', 'zach.ware', 'serhiy.storchaka', 'xiang.zhang']
pr_nums = ['1373', '1395', '1399']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue30223'
versions = ['Python 2.7']

[serhiy-storchaka]

Following patch adds Lib/test/main.py in 2.7. This allows running tests with 'python -m test' as in 3.x.

[vstinner]

Oh yes, I always wanted this tiny feature! It's painful to have to adapt my command for Python 2 after testing Python 3.

[zhangyangyu]

+1. Every time when I want to run tests for 2.7, I have to type twice. Once python -m test, error and then python -m test.regrtest.

[ncoghlan]

+1 from me. We hadn't done this (or the test.support backport) previously due to the "no new features" guideline, but I think simplifying cross-branch maintenance overrides that concerns.

[serhiy-storchaka]

New changeset 43566ae by Serhiy Storchaka in branch '2.7':
[2.7] bpo-30223: Add Lib/test/main.py. (bpo-1373)
43566ae

[serhiy-storchaka]

These new features affect only core developers and other contributors fixing bugs in 2.7. I don't think the "no new features" guideline is applicable here.

[zware]

Once again, I agree with the change, but I have an unhappy buildbot :)

http://buildbot.python.org/all/builders/x86%20Gentoo%20Non-Debug%20with%20X%202.7/builds/124

This time it is due to python 2.4 not supporting the absolute_import __future__ feature. By this point, I think we could get away with just removing the python 2.4 pickle compat tests.

[serhiy-storchaka]

Oh, it is so easy to break test_xpickle. But I think this test is very important. It is pity that test_xpickle is removed in 3.x.

I hope PR 1395 will fix test_xpickle.

[zware]

2.4 is rather far out of date, but PR1395 is simple enough. I would support re-adding test_xpickle in 3.x, and can ensure that every major version is available on that buildbot to exercise it.

[serhiy-storchaka]

New changeset 8e158b2 by Serhiy Storchaka in branch '2.7':
[2.7] bpo-30223: Fix test_xpickle for Python 2.4. (bpo-1395)
8e158b2

[serhiy-storchaka]

Thanks Zachary!

[vstinner]

Hum, it seems like test_regrtest is more and more important. Yet another regression:

http://buildbot.python.org/all/builders/x86%20Gentoo%20Installed%20with%20X%202.7/builds/126/steps/test/logs/stdio

Traceback (most recent call last):
  File "/buildbot/buildarea/2.7.ware-gentoo-x86.installed/build/target/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/buildbot/buildarea/2.7.ware-gentoo-x86.installed/build/target/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/buildbot/buildarea/2.7.ware-gentoo-x86.installed/build/target/lib/python2.7/test/regrtest.py", line 1684, in <module>
    main_in_temp_cwd()
  File "/buildbot/buildarea/2.7.ware-gentoo-x86.installed/build/target/lib/python2.7/test/regrtest.py", line 1664, in main_in_temp_cwd
    TESTCWD = os.path.join(TEMPDIR, TESTCWD)
UnboundLocalError: local variable 'TEMPDIR' referenced before assignment